Fix download counter to use correct asset for repositories with multiple release assets #4693
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The download counter was showing incorrect values for repositories with multiple release assets. The issue occurred because HACS always used the download count from the first asset in the release instead of the asset specified by the
filename
field in the repository manifest (hacs.yaml).Problem
When a repository has multiple release assets, the download counter would display the download count from the first asset rather than the correct asset. For example, the
mbapi2020
component was showing ~190 downloads (from the first asset) instead of ~4000 downloads (from the correctmbapi2020.zip
asset).Root Cause
In
custom_components/hacs/repositories/base.py
, the code usednext(iter(assets)).download_count
which always retrieves the first asset from the assets list, regardless of which asset is actually being used for the repository.Solution
Modified the download counting logic to:
self.data.file_name
(the filename specified in the repository manifest)file_name
is None (preserving existing behavior)Changes Made
custom_components/hacs/repositories/base.py
: Updated download counting logic in thecommon_update_data
methodtests/repositories/test_download_counter.py
: Added comprehensive test coverage for all scenariosValidation
The fix has been validated to:
Fixes #4438.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.