Refactor fn split #15
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now, this is not a simple clippy fix. I think you want to split a
&strwith':'and','and take out&strs that representf32. This PR should do that. Here is a set of simple tests I used. If I am missing something, please let me know.I think we should parse in this function and return
Vec<f32>instead ofVec<&str>. But that requires modification in main. Let's make sure we are good with this change first.