Implemented sorting in all functions except for two-way tables. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ng is printed if `sort = TRUE`.
theshiniss changed the title tab2.
gvelasq requested changes May 25, 2024
R/tab.R Outdated
| #' @param x A vector, data.frame, or tibble. | ||
| #' @param ... A comma separated list of unquoted variable names or positions. Select helpers from [dplyr](https://dplyr.tidyverse.org/reference/select.html) and [tidyselect](https://rdrr.io/cran/tidyselect/man/select_helpers.html) are supported. | ||
| #' @param m If `TRUE` (the default), missing values are reported. | ||
| #' @param sort If `TRUE` (default is `FALSE`), will show the largest groups at the top. Sorting is not implemented for two-way tables. |
Owner
There was a problem hiding this comment.
It might be worth mentioning here that the default behavior is to sort (ascending) by value and that sort = TRUE changes this behavior to sort (descending) by frequency.
I introduced a typo ('# missing) on line 25 
Owner
| Closes #28 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implemented sorting in all functions except for two-way tables, where a warning is printed if
sort = TRUE. Updated the help documentation accordingly.