interceptor intercepts angular-ui templates #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi Tony, thanks a lot for the pull request! :) Yes that is true it intercepts everything but I think this is a good addition. And nice that you wrote a test for it. You then need to use the head of the repository in bower such that you have these changes through bower, as I won't release a new version in the near future. Thanks and regards, Guy |
guylabs added a commit that referenced this pull request Aug 10, 2015
interceptor intercepts angular-ui templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi, thanks for sharing this great project! The only issue I had was when using SpringDataRestInterceptor, it was intercepting everything, including my angular-ui-router templates, and blowing up while trying to process them, since they're just strings.
I noticed it was blowing up here:
https://github.com/guylabs/angular-spring-data-rest/blob/master/src/angular-spring-data-rest-provider.js#L218-L221
The most unobtrusive fix that I can think of is to check that response.data is of type object before calling process(), if it's not, let it pass through unchanged.
This change cleared up the issues I was having with the angular-ui-router templates. Thanks!