- Notifications
You must be signed in to change notification settings - Fork 178
Switch to bazelmod #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Switch to bazelmod #618
Conversation
@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞 |
I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :) We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability. |
Is anything blocking review of this? It seems the CLA has been signed. |
@lowasser hey, looks like you merged last few commits. Could you help me understand what's the best process to follow to proceed with the review of this PR? |
Following rules_java example seems sane to me: https://github.com/bazelbuild/rules_java/blob/master/.gitignore#L20
Ready to merge? |
@gonzojive Yes. Waiting for maintainers to take action and unblock running of the checks (or unblock merging in a different way). |
👋 bzlmod user here. I tried the techniques seen here in my project and things seem like they are working. Thanks for the great work. |
@lowasser - Any movement on this? (also, hi!) |
@ratnikov Thanks for this work. (bzlmod user here and also blaze user as I am a Googler :P) . Eagerly waiting for this PR to be merged from past few months. I can use the same tech-stack which I am currently used-to in Google for fullstack development. |
Friendly /poke from another googler. 👋 |
Is this going ahead? Bazel 9 is coming and soon workspace will not be feasible at all. |
Hey everyone - some good news. Initial bzlmod support has now been merged. Definitely, a huge thanks to @ratnikov for getting the ball rolling on this, and to everyone here for pushing it forward. While not merged, part of the info in this PR were definitely reflected in #640. Right now, you can test it with something like:
As you may have guessed, the real maintainers are fully occupied with their primary work. To clarify, I am not real maintainer, but just have temporary permissions :). I would like to see this to the end, hopefully getting it released to the Bazel registry. In the meantime (probably the next 1-2-3 weekends), while I can't approve my own PRs (so hard to make things better on my own), I can review yours =)). if you see some bugs or improvements and willing and able to make some very simple and short changes that can be quickly verified, I am happy to review and merge them to make this better. Especially @ratnikov, I'll prioritize your PRs if any. ;) Thanks. |
Resolves #398
I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)