fix(ServerCalls): Fix regression in Status cause for exceptions thrown by implementations #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andrewparmet changed the title 
zakhenry approved these changes Nov 15, 2023
| Thanks for doing this so quick and including tests! As soon as @lowasser can review, we will get this merged and a new release rolled. |
lowasser approved these changes Nov 16, 2023
| I'm rolling the 1.4.1 release now. Thanks again @andrewparmet for the quick fix and thank you @zakhenry and @lowasser for the reviews! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ensures that Statuses derived from StatusExceptions and StatusRuntimeExceptions match their behavior before #400. This is also
grpc-java's behavior whenonErroris called with a StatusException or StatusRuntimeException.Fixes #455.