Skip to content

core: fix boq conformance failures #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2021
Merged

core: fix boq conformance failures #8281

merged 2 commits into from
Jun 24, 2021

Conversation

YifeiZhuang
Copy link
Member

@YifeiZhuang YifeiZhuang commented Jun 23, 2021 •
edited
Loading

Conformance failure due to blocking IO call (future.get())
reproduced and verified the fix

reference: go/boq-conformance-violations/BLOCKING#what-should-i-do-instead
@YifeiZhuang YifeiZhuang changed the title core: attempting to fix boq complaints core: attempt to fix boq conformance failures Jun 24, 2021
@YifeiZhuang YifeiZhuang changed the title core: attempt to fix boq conformance failures core: fix boq conformance failures Jun 24, 2021
@YifeiZhuang YifeiZhuang requested a review from sergiitk June 24, 2021 00:37
sergiitk
sergiitk reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM, but I don't have full context to judge the impact of this change. @ejona86 mind giving this a look, since you reviewed the original PR #8266?
@sergiitk sergiitk requested a review from ejona86 June 24, 2021 02:25
@YifeiZhuang YifeiZhuang merged commit c1ad5de into grpc:master Jun 24, 2021
@YifeiZhuang YifeiZhuang deleted the zivy/fix branch June 24, 2021 15:07
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Jun 25, 2021
@YifeiZhuang
Revert "core: fix boq conformance failures (grpc#8281)"
72ae12b 
This reverts commit c1ad5de.
YifeiZhuang added a commit that referenced this pull request Jun 25, 2021
@YifeiZhuang
core: rollback executor supplier, needs investigation (#8289)
1b57d48 
* Revert "core: fix boq conformance failures (#8281)" This reverts commit c1ad5de. * Revert "core: allow per-service/method executor (#8266)" This reverts commit c540229.
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Jul 25, 2021
@YifeiZhuang
core: fix boq conformance failures (grpc#8281)
5cc5779 
Fix false alarm to please boq conformance verifications, ref. go/boq-conformance-violations/BLOCKING#what-should-i-do-instead.
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Jul 25, 2021
@YifeiZhuang
core: rollback executor supplier, needs investigation (grpc#8289)
240aaf5 
* Revert "core: fix boq conformance failures (grpc#8281)" This reverts commit c1ad5de. * Revert "core: allow per-service/method executor (grpc#8266)" This reverts commit c540229.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@YifeiZhuang @sergiitk @ejona86