netty: Abrupt GOAWAY should not cause INTERNAL status #7501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The stream creation was failing because the stream id was disallowed: Caused by: io.grpc.StatusRuntimeException: INTERNAL: http2 exception at io.grpc.Status.asRuntimeException(Status.java:533) at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:629) ... 16 more Caused by: io.grpc.netty.shaded.io.netty.handler.codec.http2.Http2Exception$StreamException: Cannot create stream 222691 greater than Last-Stream-ID 222689 from GOAWAY. The problem was introduced in 9ead606. Fixes grpc#7357
ejona86 added the TODO:backport 
dapengzhang0 approved these changes Oct 15, 2020
| Does this need be backported to 1.33 release? |
ejona86 removed the TODO:backport 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The stream creation was failing because the stream id was disallowed:
The problem was introduced in 9ead606. Fixes #7357