Skip to content

Conversation

@DNVindhya
Copy link
Contributor

This PR adds a CSM Observability example. This is intended to be built as docker images and deployed as part of CSM observability user guide.

@DNVindhya DNVindhya requested a review from ejona86 June 6, 2024 02:45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use jib. As in another example:

jib {
from.image = "gcr.io/distroless/java17-debian12"
container.ports = ['50051']
outputPaths {
tar = 'build/example-hostname.tar'
digest = 'build/example-hostname.digest'
imageId = 'build/example-hostname.id'
}
}

If we want, we can have the dockerfile as well, but we shouldn't root it in grpc-java but instead expect it to be built in the example-gcp-csm-observability directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is related to automating container image generation, I will add it in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it was more I don't want us to use Dockerfile because they are harder to integrate and produce worse results. But since you've gotten the Dockerfile approach working, I guess that's fine... but... yeah, I had wanted us to push jib in the documentation.

@DNVindhya DNVindhya requested a review from yashykt June 6, 2024 21:52
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix up the comment style, then LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it was more I don't want us to use Dockerfile because they are harder to integrate and produce worse results. But since you've gotten the Dockerfile approach working, I guess that's fine... but... yeah, I had wanted us to push jib in the documentation.

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Jun 12, 2024
@DNVindhya DNVindhya merged commit 889893d into grpc:master Jun 13, 2024
@DNVindhya DNVindhya deleted the csm-o11y-example branch June 13, 2024 20:12
DNVindhya added a commit to DNVindhya/grpc-java that referenced this pull request Jun 13, 2024
Add GCP CSM observability example client and example server.
@DNVindhya DNVindhya removed the TODO:backport PR needs to be backported. Removed after backport complete label Jun 13, 2024
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
Add GCP CSM observability example client and example server.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants