xds: fix test failure in xds flow control #10773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
larry-safran approved these changes Dec 20, 2023
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Dec 27, 2023
This reverts commit f67ec2e.
YifeiZhuang added a commit that referenced this pull request Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The issue is that when I block in mock
Answer, g3 test count that as a method invocation.It looks local environments and OSS CI didn't report the problem.
Because we still test that the 2nd message was not delivered due to flow control, it is still fine.
After the fix TAP seems happy, fusion
cc. @danielzhaotongliu