Enable indirect addressing using <intent-filter>s. #10550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AndroidComponentAddress now accepts an Intent with merely a package restriction, not a full ComponentName. This lets clients avoid hard coding Service class names that they don't control. Fixes #9062
ejona86 approved these changes Sep 12, 2023
Member
ejona86 left a comment
ejona86 left a comment There was a problem hiding this comment.
I doubt much outside of gRPC is even calling getComponent(), and even if they are, it only breaks when someone uses the new feature. Seems pretty safe.
markb74 approved these changes Sep 12, 2023
DNVindhya pushed a commit to DNVindhya/grpc-java that referenced this pull request Oct 5, 2023
AndroidComponentAddress now accepts an Intent with merely a package restriction, not a full ComponentName. This lets clients avoid hard coding Service class names that they don't control. Fixes grpc#9062
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AndroidComponentAddress now accepts an Intent with merely a package restriction, not a full ComponentName. This lets clients avoid hard coding Service class names that they don't control.
Experimental API AndroidComponentAddress#getComponent() becomes nullable, which is technically a breaking change. But we expect the impact will be small since existing callers mostly work with addresses they created themselves, which will have a non-null ComponentName.
Fixes #9062