Skip to content

Stderr is now by default UTF-8 #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 1, 2024
Merged

Stderr is now by default UTF-8 #624

merged 9 commits into from
Jan 1, 2024

Conversation

@ArneTR
Copy link
Member

@ArneTR ArneTR commented Dec 23, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 23, 2023 •
edited
Loading

Old Energy Estimation

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 10.9072 1676.86 2.57583 659
Measurement #1 10.9696 1676.86 2.57583 652

📈 Energy graph:

 7.70 ┤ ╭╮ ╭╮ 7.10 ┤ ││ ││ 6.51 ┤ ╭╮ ╭╯│ ╭╮ ││ 5.92 ┤ │╰─╮ │ │ │╰╮ ││╭╮ 5.33 ┤ │ ╰╮ │ │ ╭╯ ╰╮╭╯╰╯│ 4.73 ┤ ╭╮│ │ │ ╰─╮╭─╮╭╮ ╭╯ ││ │ ╭╮ 4.14 ┤ ╭╯╰╯ │ ╭─╮╭──╮ ╭╮ ╭───╮ │ ╰╯ ╰╯╰╮ │ ╰╯ ╰╮ ╭─╮││ ╭───╮╭╮╭─╮ ╭─╮ ╭╮ ╭╮ ╭────╮ ╭╮ ╭╮ ╭╮ ╭───╮ ╭─╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭─╮ ╭╮╭╮ ╭╮ ╭╮ ╭───╮ ╭─ 3.55 ┤ ╭╯ ╰───╯ ╰╯ ╰──╯╰───╯ ╰╮╭╯ │ │ │ ╭╯ ╰╯╰─╮ ╭──╮ ╭╮ ╭╯ ╰╯╰╯ ╰─╯ ╰─╮ │╰─╮ ╭───╮ ╭──╮ ╭──╮ ╭───╯╰──╯ ╰────────────╯╰╮ │╰─╮ ╭──╮ ╭──╮ ╭──╮ │╰─╮ │ │ ╭╮ ╭╮ ╭╯ ╰╮ ╭╮╭─╯╰─╮ ╭╮ ╭╯╰─╮ ││╭╮ ╭╮╭─╯╰─╮ ╭╮ ╭╮╭─╯╰─╮ ││╭╮ ╭╮ │ ╰─╮ ╭──╮ ╭╮ ╭──╮ ╭─╮ ╭──╮ ╭─╮ ╭─╮ │╰╯╰╮ ╭──╮ │╰─╮ ╭─╮ │╰─╮ ╭─╮ ╭╯ ╰─╮ ╭─╮ ╭╮ │ 2.95 ┤ │ ││ ╰╮│ │ │ │ │ │ ││ │ │ │ │ │ │ │ │ │ │ │ │ ╭╯ │ │ │ │ │ │ │ │ │ │ │ ││ ││ │ │ ╭╮ │││ │ ││ │ ╰╮ ╭╯│││ │││ │ │╰─╮ ╭╯││ │ ││││ ││ │ │ │ │ ││ │ │ ╭╯ │ │ │ │ ╰╮ ╭╯ │ │ │ │ │╭╮ │ │ │ ╰╮ │ │ │ ╰╮ │ │ │ ╰╮ ││ │ 2.36 ┤ │ ╰╯ ││ │ │ │ ╭╯ │ ││ │ │ │ ╰╮ │ │ │ ╰╮ │ │ │ │ │ │ │ │ │ ╰╮ │ │ │ ╰╮ │ ╰╮ ││ ││ │ ╰╮ ││ ╭╯││ │ ╭╮ ││ │ │ │ │││ ╭╯││ │ ╭╯ │ │ ││ │ ╭╯╰╯│ ╭╯│ │ │ ╭╯ │ ││ │ ╰╮ │ │ ╭╯ │ │ │ │ │ │ │ ╭╯ ╰╯│ ╭╮ │ │ │ │ │ │ ╭╯ │ │ │ │ │ ││ │ 1.77 ┼────╯ ╰╯ ╰───────╯ ╰───────╯ ╰────────╯╰─╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰────────╯╰────────╯╰─╯ ╰────────╯╰───────╯ ╰╯ ╰────────╯╰────────╯╰─╯ ╰───────╯ ╰╯╰───────╯ ╰╯ ╰───────╯ ╰───────╯ ╰╯ ╰───────╯ ╰───────╯ ╰─╯ ╰───────╯ ╰────────╯╰─╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰───────╯ ╰───────╯╰─╯ ╰────────╯ ╰──────────╯ ╰───────╯ ╰──────────╯ ╰────────╯ ╰────────╯╰─╯ Watts over time
@ArneTR ArneTR requested a review from ribalba December 23, 2023 11:30
@ArneTR
Copy link
Member Author

ArneTR commented Dec 28, 2023

@ribalba Can you give me an estimation when you can review this for my planning?
ribalba
ribalba approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@ribalba ribalba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would also remove all the checks for stderr is None in this PR or we can also do it while refactoring the code later on
metric_providers/base.py
stderr_read = self._ps.stderr.read()
if isinstance(stderr_read, bytes):
stderr_read = stderr_read.decode('utf-8')
return stderr_read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we always return the empty string we can remove quite a few checks for stderr being None
ArneTR added 4 commits January 1, 2024 07:55
@ArneTR
stderr is always string, so we can remove None check
bad1c6c
@ArneTR
Merge branch 'main' into stderr-utf8
88ea4e8 
* main: Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636) GMT color via own commit hash (#634) Hotfix for branch not main Non-Blocking starlette body read (#633) Bump fastapi from 0.105.0 to 0.108.0 (#632) Updated XGBoost submodule Bump pydantic from 2.5.2 to 2.5.3 (#628) Added stddev to timeline (#627)
@ArneTR
Merge branch 'main' into stderr-utf8
8ee4c87 
* main: Refactored kill/killpg mechanism to be unified and actually fail on n… (#625)
@ArneTR
Refactoring
d40993f
@github-actions
Copy link

github-actions bot commented Jan 1, 2024

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 9.88767 1729.14 2.53168 691
Measurement #1 9.91344 1729.14 2.53168 685

📈 Energy graph:

 7.74 ┤ ╭╮ 7.14 ┤ ╭╮ ││ 6.55 ┤ ││ ╭╮ ││╭╮ 5.95 ┤ ╭╯│ ╭╯│ ││││ 5.35 ┤ │ │ │ ╰╮╭╯│││ 4.75 ┤ ╭─╮ ╭╮ │ ╰╮ ╭─╮╭╮ ╭╯ ││ ╰╯│ 4.16 ┤ ╭╯ ╰╮ │╰──╮╭╮ ╭─╮ ╭╮╭╮ │ ╰─╯ ╰╯╰╮ ╭╯ ╰╯ │ ╭╮ ╭╮╭─╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭─────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮╭╮ ╭─╮ ╭ 3.56 ┤ ╭╮╭─╯ ╰───╯ ╰╯╰──╮│ ╰───╯╰╯│ │ │ │ ╰╮ ││ │││ ╰╮ ╭╮ ╭╮ ╭───╯│╭╯╰─╯╰──╯╰─╮ │╰─╮ ╭───╮ ╭──╮ ╭──╮ ╭──╮│╰──╯ ╰──╮╭─╮╭───────╮ ╭───╮ ╭──╮ ╭──╮ ╭──╮ ╭───╮ ╭╯╰─╮ ╭╮ ╭─╯╰─╮ ╭╮ ╭─╯╰─╮ ╭╮ ╭─╯╰─╮ ╭╮╭╮ ╭╮ ╭╯╰─╮ ╭╮ ╭╮ ╭╯╰─╮ ╭╮╭╮ ╭╮╭─╯╰─╮ ╭─╮ ╭╮ ╭───╮ ╭─╮ ╭╮╭─╮ ╭─╮ ╭─╮ │││╰╮ ╭─╮╭╮╭╮ ╭╮╭─╮ ╭─╮ ╭──╮ ╭╮ ╭──╯ ╰─╮ ╭╮ ╭╮ ╭╯ 2.96 ┤ │││ ││ ╰╮╭╮ ╭╮│ ╰╮ │ │ │╰╮│││ │ ╭─╯│╭╮ │╰╮│ ╰╯ │ │ ╰╮ │ │ ╭╯ │ ╭╯ │ ╭╯ ││ ╰╯ ││ │ │ │ │ ╰╮ │ │ │ │ │ │ ╭╯ │ ││ │ │ ╭╮ │╰╮│ │ ││ │ │ │╰╯│ ││ │ │ ││╭╮ │╰╮│ ╰╮ ││││ ╭╯││ │ │ │╭╮ │╰╮│ │ │ │ │╰╯ │ │ │ ╭╯ │ │╰╯ │ │ ││╰╯│ │╰╯ │ │ │ │ │ ││╭╮ │ │ ││╭╮ │╰╮│ 2.37 ┤ │││ ╰╯ ╰╯│ ╭─╯╰╯ │ │ │ │ ╰╯╰╯ │ │ │││ ╭╮ │ ││ │ │ │ │ │ │ │ │ │ │ ││ ││ ╰╮ │ │ │ │ │ ╰╮ │ │ │ │ │ │ ╭─╮ │╰╮│ │ ││ │ ││ │ ││ │ │ ╭╮│ │ ││ │ │ ╭─╯│││ │ ││ │ ╭╮╭╯│││ │ ││ │ │ │││ │ ││ │ │ ╰╮ │ │ │ ╰╮ │ │ │ │ ╭╮│ ││ │ ╭╮│ │ ╭╮│ ╰╮ │ ╰╮ ╭─╯╰╯│ │ ╰╮ ╭╮││││ │ ││ 1.77 ┼──────╯╰╯ ╰─╯ ╰──╯ ╰───────╯ ╰────────╯ ╰╯╰─╯╰────╯ ╰╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰╯ ╰╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰───────╯ ╰╯ ╰─────────╯╰───────╯ ╰╯ ╰──────────────────╯╰─╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰───────╯╰╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰───────╯╰╯ ╰╯ ╰────────╯╰╯ ╰───────╯╰╯ ╰──────────╯ ╰───────╯ ╰──────────╯ ╰───────╯╰╯╰╯╰───────╯ ╰╯ Watts over time
@ArneTR ArneTR merged commit 32575a8 into main Jan 1, 2024
@ArneTR ArneTR deleted the stderr-utf8 branch January 1, 2024 07:13
ArneTR added a commit that referenced this pull request Jan 1, 2024
@ArneTR
Merge branch 'main' into system-check-providers-running
a6acf04 
* main: Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636) GMT color via own commit hash (#634) Hotfix for branch not main Non-Blocking starlette body read (#633) Bump fastapi from 0.105.0 to 0.108.0 (#632) Updated XGBoost submodule Bump pydantic from 2.5.2 to 2.5.3 (#628) Added stddev to timeline (#627) Disable tinyproxy systemd service (#623)
ArneTR added a commit that referenced this pull request Jan 1, 2024
@ArneTR
Merge branch 'main' into adds-skip-checks-to-providers
bcd51e9 
* main: (23 commits) System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636) GMT color via own commit hash (#634) Hotfix for branch not main Non-Blocking starlette body read (#633) Bump fastapi from 0.105.0 to 0.108.0 (#632) Updated XGBoost submodule Bump pydantic from 2.5.2 to 2.5.3 (#628) Added stddev to timeline (#627) Disable tinyproxy systemd service (#623) Text change Value formatting on status page Normalized URL for machines endpoint Less confusing error messages Status has now a waiting time (#599) ...
ArneTR added a commit that referenced this pull request Jan 1, 2024
@ArneTR
Merge branch 'main' into dev-mode
24bfc5b 
* main: Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636)
ArneTR added a commit that referenced this pull request Jan 1, 2024
@ArneTR
Merge branch 'main' into dev-mode-timetravel
0ca8464 
* main: Dev mode (#637) Hotfix: resolutions -> resolution Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636)
ArneTR added a commit that referenced this pull request Jan 2, 2024
@ArneTR
Merge branch 'main' into measurement-control-validate
de2cb43 
* main: Dev mode (#637) Hotfix: resolutions -> resolution Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636) GMT color via own commit hash (#634) Hotfix for branch not main Non-Blocking starlette body read (#633) Bump fastapi from 0.105.0 to 0.108.0 (#632) Updated XGBoost submodule Bump pydantic from 2.5.2 to 2.5.3 (#628) Added stddev to timeline (#627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ArneTR @ribalba