Run ID is now accessible even after fail and thus can be sent via ema… #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…il; Refactorings for private attributes
Old Energy EstimationEco-CI Output:
📈 Energy graph: 7.65 ┤ ╭╮ 7.06 ┤ ╭─╮ ╭╮ ││ 6.47 ┤ │ │ ││ ││ ╭╮ 5.88 ┤ │ │ ││ │╰╮││ 5.30 ┤ ╭╮╭╮ │ │ ╭╯╰─╮ │ ╰╯│ 4.71 ┤ ││││ ╭╮╭─╮ │ ╰─╮╭───╮ ╭╯ │ │ │ 4.12 ┤ ╭╮╭─╯╰╯╰╮╭╮╭─╮╭──╮╭──╮ ╭─╮ ╭───╮╭╯╰╯ │╭──╮ │ ╰╯ ╰╮ │ ╰╮ │ │ ╭╮ ╭╮╭─╮ ╭──╮╭─╮╭─╮ ╭─╮╭╮ ╭╮╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭─╮╭╮ ╭─╮ ╭╮╭─╮ ╭╮╭╮ ╭╮╭╮ ╭─╮ ╭╮ ╭╮ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ 3.53 ┤ ╭╮│╰╯ ╰╯╰╯ ││ ╰╯ ╰──╯ ╰──╮╭╯ ╰╯ ╰╯ │ ╭╮ │ │ │ │ │ │ ╭╯│ │││ ╰─╮ ╭─╮ ╭╮ ╭─╯ ╰╯ ╰╯ ╰─╯ ╰╯│ │││╰╮ │╰╯│ ╭─╯│ ╭─╯│ ╭─╯│ ╭───╮ ╭╯╰╮ ╭╯╰╮ ╭─╯╰╮ ╭───╮ │ ╰╯│ ╭╮ ╭╮╭──╯ │ ╭╮ │╰╯ │ ╭╮ ╭╯╰╯│ ╭─╮ ╭╮ ╭╯╰╯│ ╭╮ ╭╮ │ ╰─╮ ││╭╮ ╭╮╭─╯╰─╮ ╭╮╭╮ ╭╮╭───╮ │╰╮ │╰╯│ │╰╮ ╭╯│ ╭╯╰─╮ ╭╮ ╭╮╭╮ ╭─╯│ ╭╮ ╭──╮ ╭╮ ╭─╯╰─╯╰─╮ ╭╮ ╭╮ ╭─╮ 2.94 ┤ │││ ╰╯ ││ ╰╮││ ╭╮╭╯ │ │ ╰─╯ │ ╭╯ │ │││ │ ╭╮│ │ │╰╮│ │ │╰╯ │ ╭╯ │ │ │ │ │ │ ╰╮ │ │ │ │ │ │ │ │ │ │ │ │ ││ │││ ╰╮ ╭╮ ││ │ │ ╭╮ ││ │ │ ╭╯ │ ││ │ ╰╮ ╭╯╰╮ ││ │ │ ││││ ╭╯││ │ ││││ ╭╯││ │ ╭╯ │ │ │ ╭╯ │ │ │ │ │ │╰╮││││ │ ╰╮ │╰─╮ │ │ ││╭╮ │ │ ││╭╮ │╰╮│ │ 2.36 ┤ │╰╯ ││ │││ ╭╯╰╯ │ │ ╰╮ │ ╰─╯╰╯ │ │││ ╰─╮ ╭╮ │ ││ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ ╭╯ │ │ │ │ │ │ │ ││ ╭╯││ │ ││ ││ │ ╰╮ ││ ││ │ │ ╭─╯ │ ││ │ │ ╭╮│ │ ││ │ │ ╭─╯│││ │ ││ │ ╭╯│││ │ ││ │ │ │ ╭╯ │ │ │ │ ╰╮ │ │ ╭─╯ ╰╯│││ ╭╮ │ │ ╭╮│ │ │ │ ╭╯│││ │ │ ╭─╯│││ │ ││ ╰╮ 1.77 ┼──────╯ ╰╯ ╰╯╰─╯ ╰───╯ ╰──────╯ ╰───────╯╰╯ ╰──╯╰───╯ ╰╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯╰────────╯╰─╯ ╰────────╯╰────────╯╰─╯ ╰────────╯ ╰────────╯╰─╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰╯╰───────╯╰─╯ ╰───────╯╰╯ ╰──────────╯ ╰─────────╯ ╰╯╰─────────╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰──────── Watts over time |
ribalba approved these changes Dec 20, 2023
global var? What do you mean? |
|
| Eco-CI Output:
📈 Energy graph: 7.78 ┤ ╭╮ ╭╮ 7.18 ┤ ││ ││ 6.58 ┤ ││ ││ 5.97 ┤ │╰╮ ╭─╮ │╰╮╭╮ 5.37 ┤ ╭╮ │ │ ╭╯ ╰╮ │ ╰╯│ 4.77 ┤ ││ ╭╮ │ ╰╮╭─╮╭╮ │ │ │ │ 4.17 ┤ ╭╯╰─╮ ╭─╮ ╭──╮ ╭─╮ │╰╮ ╭╯ ╰╯ ╰╯╰╮ │ ╰╮│ │ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ 3.57 ┤ ╭╮╭──╯ ╰──╯ ╰────╯ ╰───────╯ ╰──────╯ ╰─╮ ╭─╯ │ │ ╰╯ │ ││╭╯││╰─╮ ╭╮ ╭╮ ╭───╯╰─────╯╰─╯╰──╮ ╭──╮ ╭╮╭─╮ ╭╮╭─╮ ╭──╮ ╭──╮╭────╯ ╰──────╮╭────────╮ │╰─╮ ╭──╮ ╭──╮ ╭──╮ ╭───╮ ╭╯╰─╮ ╭╮ ╭╮╭─╯╰─╮ ╭╮ ╭╯╰─╮ ╭╮╭─╯╰─╮ ╭╮╭╮ ╭╮ ╭╯╰─╮ ╭╮ ╭╮╭─╯╰─╮ ╭─╮ ╭╮ ╭╯╰─╮ ╭╮╭╮ ╭╮ ╭──╮ ╭──╮ │╰─╮ ╭─╮ ╭─╮ │╰──╮ ╭─╮╭╮╭╮ ╭───╮ ╭─╮ ╭──╮ ╭─╮ ╭─╯╰─────╮ ╭╮ ╭╮ ╭─ 2.97 ┤ │││ ╰─╮ │ ╰╮ ╭╯ │ ╭╯╰╯ ││ │ ╭╯│╭╮ │╰╮│ │ │ │ │╰╯ │ │╰╯ │ ╭╯ │ │ ││ ││ │ │ ╰╮ │ ╰╮ │ ╰╮ │ │ │ │ │ │ ││ ╭╯││ │ ╭╮ ││╭╯ │ ╭╮ │││ │ ││││ ││ │ │ ││╭╮ │││ │ │ ╰╮ ││ │ ╰╮ ││││ ││ │ │ │ │ │ ╰╮ │ │ ╭╯ │ │ │ │ │││││ │ │ │ │ │ │ │ │ │ │ │╰─╮ ││╭╯ 2.37 ┤ │││ ╰╮╭╯ │ ╭╯ │ │ ││ │ │ ╰╯│ │ ││ │ ╭╯ ╰╮ │ │ │ │ │ │ ╭╯ ││ ││ │ ╭╯ │ │ │ │ │ │ ╰╮ ╭╮│ │ ╭╯ │ ││ │ ││ ╰╮ ││ ╭╯││ │ ││ ╭╯││ │ ╭─╯╰╯│ ││ │ │ ╭─╯╰╯│ ╭╯││ │ ╭╮│ │ ││ │ │ ╭╮│╰╯│ ││ │ ╰╮ │ │ │ │ ╭╯ │ │ │ ╭╯ │ ╭╮│ ││╰╯│ │ │ ╭╮│ ╰╮ │ ╰╮ ╭╮│ ╰╮ │ │ ╭╮│ │ ╭╯││ 1.77 ┼──────╯╰╯ ╰╯ ╰─╯ ╰───────╯ ╰╯ ╰─────────╯ ╰───────╯ ╰╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰╯ ╰╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰──────╯╰╯ ╰────────╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯╰───────╯ ╰╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯ ╰────────╯╰─╯ ╰────────╯ ╰───────╯ ╰╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰───────╯╰╯ ╰╯ ╰──────────╯ ╰───────╯╰╯ ╰──────────╯ ╰───────╯╰╯ ╰──────────╯ ╰───────╯╰╯ ╰───────╯ ╰╯ Watts over time |
| I'll explain on the phone. Nothing that stops the merge. |
ArneTR added a commit that referenced this pull request Dec 23, 2023
* main: (26 commits) Disable tinyproxy systemd service (#623) Text change Value formatting on status page Normalized URL for machines endpoint Less confusing error messages Status has now a waiting time (#599) Run ID is now accessible even after fail and thus can be sent via ema… (#601) Switched from cmd to command (#615) Hotfix for check on frequency provider Tests run_until must be guard-claused with cleanup routine (#616) Fix check if stderr is empty (#613) Bump uvicorn[standard] from 0.24.0.post1 to 0.25.0 (#612) Fxing the network provider stderror Branch and filename are now always not null (#602) Adds a more elaborate depends_on test Support reading notes from services (#590) docker build command in tests now checks reason for docker build failure. If it is a permission issue with the cache, it will continue the rest of the workflow (#576) Use depends_on for container startup order (refactored) (#593) Bump psycopg[binary] from 3.1.15 to 3.1.16 (#610) Added powercap info to hardware_info (#609) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes the confusing email behaviour that sometimes this would be show:
Since the run_id could not be seen when a run was failed it would show up as None in the email.
This lead to the further complication that some email programs want to generate a link preview and access this URL. This lead to further error emails for 404 access and so on ...
Now run_id is always transported and if really not present then no link is shown