Clarify 'Values of Correct Type' rule relates to literals

[benjie]

An Input Value is defined as being either a variable (if not const) or one of the literal types (IntValue, FloatValue, StringValue, BooleanValue, NullValue, EnumValue, ListValue or ObjectValue).

The rule "Values of Correct Type" states:

• For each input Value value in the document:
  • Let type be the type expected in the position value is found.
  • value must be coercible to type.

However, an input value can be a variable, and variable coercion is handled at runtime (by CoerceVariableValues). Further, we already have a rule that validates that variables are only used in the positions in which they are allowed: All Variable Usages Are Allowed.

It seems to me that "Values of Correct Type" only meant to handle literal input values, so I've added the word "literal" for clarity. I've also expanded the explanation to reference where to look for variable input value validation. Since input coercion for Input Object references "runtime value", and validation doesn't have access to runtime values, I've made explicit the assumption that values represented by variables will be of the requisite type.

This is an alternative solution to, and

• fixes Add note above variables to Values of Correct Type rule #1113

Thank you to @yaacovCR for pointing out this deficiency 🙌

[netlify]

✅ Deploy Preview for graphql-spec-draft ready!

Name	Link
🔨 Latest commit	0c25faa
🔍 Latest deploy log	https://app.netlify.com/sites/graphql-spec-draft/deploys/67cb1b5057e42c0008fe671e
😎 Deploy Preview	https://deploy-preview-1118--graphql-spec-draft.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[benjie]

@graphql/tsc I would love to get your input on this change.

[martinbonnin]

Good clarification 👍

Left a few additional questions that arose while doing the review but the PR in itself is an improvement from the current state and I support merging it.