Skip to content

Conversation

@benjie benjie merged commit d285c9f into main Mar 28, 2024
@benjie benjie deleted the oversse branch March 28, 2024 08:52
@bclozel
Copy link

bclozel commented Mar 28, 2024

Is there a consistent way to detect whether clients use EventSource, or is this really a local implementation choice? If there is no consistent way, shouldn't the server always send data: with the complete event or are there downsides to doing that?

@enisdenjo
Copy link
Member Author

@bclozel there is no way to detect the client. You could manually indicate to the server through headers, but EventSource in browser doesnt allow changing headers.

graphql-sse always sends the data: , there is no reason against it. The only drawback is you send 6 more bytes, but I dont think this is a biggie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants