Fix publish scripts #4104
Merged
Fix publish scripts #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
benjie added a commit that referenced this pull request Jun 21, 2024
This was referenced Jun 21, 2024
This was referenced Jul 4, 2024
This was referenced Jul 4, 2024
This was referenced Jul 12, 2024
This was referenced Sep 11, 2024
This was referenced Sep 19, 2024
Thompson1985 approved these changes Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The publish scripts require the shell to be
bash, which despite being the shell I use is not the one thatnpm versionseems to use currently. Fixed by forcing the script to run throughbash -cThis will NOT work on Windows. Probably it already didn't.