execute: code refactors related to steam/defer #3878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
to match type
to match type
= integrate locatedError, which was always called on the input = avoid constant return value, which causes return value to hide value of this constant = add optional asyncPayloadRecord parameter so that caller does not have to supply errors list
to executeStreamAsyncIterator
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR added the PR: polish 💅 
| You have successfully added a new CodeQL configuration |
Contributor Author
| meant for each commit to be added separately, i.e. "rebase and merge" rather than "squash and merge" |
saihaj approved these changes Apr 5, 2023
IvanGoncharov approved these changes Apr 5, 2023
Member
IvanGoncharov left a comment
IvanGoncharov left a comment There was a problem hiding this comment.
@yaacovCR Thanks for splitting it into separate commits; it was a pleasure to review.
robrichard approved these changes Apr 5, 2023
IvanGoncharov changed the title yaacovCR added a commit that referenced this pull request May 16, 2023
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 13, 2025
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
missed by me both in graphql#3891 and graphql#3878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
extracted from #3862