github actions: switch embedded JS to ESM #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Motivation: API calls to GH are async and require top-level await. Also add 'node:' prefix to all node modules.
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 3, 2022
I did 'require => import' change together with top-level await change in graphql#3612 I assumed if top-level `async` is working it means `import` should also work. In reality, `actions/github-script` was passing code to async function constructor. That means top-level await is not really top-level since it gets injected into a function and we still execute in CJS context and `import` will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation: API calls to GH are async and require top-level await.
Also add 'node:' prefix to all node modules.