Skip to content

Conversation

@IvanGoncharov
Copy link
Member

Extracted from #3564
Motivation: __dirname and require.resolve is CJS specific mechanism
and we use them in multiple places. Even without ESM migration this
function makes internal scripts more high-level and thus readable.

@netlify
Copy link

netlify bot commented May 28, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit d608da5
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/629201bea0c1d60008c50103
😎 Deploy Preview https://deploy-preview-3610--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM
Extracted from graphql#3564 Motivation: `__dirname` and `require.resolve` is CJS specific mechanism and we use them in multiple places. Even without ESM migration this function makes internal scripts more high-level and thus readable.
@IvanGoncharov IvanGoncharov merged commit be42e7c into graphql:main May 28, 2022
@IvanGoncharov IvanGoncharov deleted the pr_branch2 branch May 28, 2022 11:09
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant