This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Convert remaining files to TypeScript #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danielrearden force-pushed the convert-to-ts2 branch 7 times, most recently from c4e19fb to b8fb28b Compare 
danielrearden force-pushed the convert-to-ts2 branch 6 times, most recently from 14b7164 to 59bd4f7 Compare danielrearden force-pushed the convert-to-ts2 branch 4 times, most recently from 6e8662e to 920e614 Compare danielrearden force-pushed the convert-to-ts2 branch from 920e614 to c03765b Compare src/index.ts Outdated
| let formatErrorFn = formatError; | ||
| let formatErrorFn: ( | ||
| error: GraphQLError, | ||
| ) => GraphQLFormattedError = formatError; |
There was a problem hiding this comment.
Can it be typeof formatError?
There was a problem hiding this comment.
Thanks. Actually, let formatErrorFn = formatError is sufficient now. Had to specify the type before only because of differences in the return types.
danielrearden force-pushed the convert-to-ts2 branch from c03765b to 6a8432a Compare 
IvanGoncharov added the PR: polish 💅 junminstorage pushed a commit to junminstorage/express-graphql that referenced this pull request Aug 14, 2020
This was referenced Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.