This repository was archived by the owner on Mar 20, 2023. It is now read-only.
TS: Allow to pass object as graphiql option #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Workaround for now: app.use('/graphql', graphqlHTTP({ context, graphiql: <boolean> <unknown> { defaultQuery: config.defaultQuery, }, schema, })); |
When using typescript, it is not allowed to pass an object as graphiql value. Only boolean values are allowed. This disables the user to set his own defaultQuery that is shown by default on GraphiQL render.
| Anyone could merge this? |
IvanGoncharov added the PR: bug fix 🐞 IvanGoncharov changed the title Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using typescript, it is not allowed to pass an object as graphiql value. Only boolean values are allowed. This disables the user to set his own defaultQuery that is shown by default on GraphiQL render.