This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Fix GraphiQL font rendering #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The GraphiQL page-level font-family CSS rules are not applying because the `renderGraphiQL.js` page uses a JS-type comment in a `<style>` block. This PR is a quick fix to change to use the CSS style comment `/* ... */` so that the first CSS rule doesn't get skipped.
| @sjparsons Thanks a lot 👍 |
IvanGoncharov added the PR: bug fix 🐞 Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The GraphiQL page-level font-family CSS rules are not applying because the
renderGraphiQL.jspage uses a JS-type comment in a<style>block.This PR is a quick fix to change to use the CSS style comment
/* ... */so thatthe first CSS rule doesn't get skipped.
Before
After