This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Add support for customParseFn option #484
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Attempt to address #483.
The current implementation in this PR provides support for synchronous
customParseFnfunctions.Eventually I think that it would be worthwhile also supporting asynchronous functions. i.e. have the
customParseFnreturn type be a (let's see if i get the Flow type correct)?Promise<DocumentNode>. Unfortunitely I couldn't quite get the promise handling.then().catch()logic right at this point in time... even when requiring thecustomParseFnbe async (vs. maybe async).