Skip to content

Export directive to support batch processing. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Export directive to support batch processing. #99

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0455431
Export directive to support batch processing.
boneill42 Jan 4, 2017
3f93274
Passing test, removed debugging
boneill42 Jan 4, 2017
023dbb2
append the value
boneill42 Jan 4, 2017
fbc07b9
s/pdb//g
boneill42 Jan 4, 2017
c027167
Removing dep on Export, not needed here.
boneill42 Jan 23, 2017
caf8e30
Merge branch 'master' of github.com:graphql-python/graphql-core into …
boneill42 Apr 24, 2017
206c51e
no prints
boneill42 Apr 24, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Passing test, removed debugging
  • Loading branch information
@boneill42
boneill42 committed Jan 4, 2017
commit 3f932744414a7e8baf7d4d595e518c62ec4f53b7
1 change: 0 additions & 1 deletion graphql/execution/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def collect_fields(ctx, runtime_type, selection_set, fields, prev_fragment_names
for directive in directives:
if directive.name.value == GraphQLExportDirective.name:
variable = get_argument_values(GraphQLExportDirective.args, directive.arguments)['as']
import pdb; pdb.set_trace()
ctx.variable_values.setdefault(variable, []).append(selection.name.value)

if not should_include_node(ctx, directives):
Expand Down
2 changes: 1 addition & 1 deletion graphql/execution/tests/test_directives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_export():
result = execute_test_query('{ a, b @export(as: "ids") }')
assert not result.errors
assert result.data == {'a': 'a', 'b': 'b'}
assert result.variable_values == {'ids': 'b'}
assert result.variable_values == {'ids': ['b']}


def test_if_false_omits_on_scalar():
Expand Down