Use promise.get() instead of promise.value in executor #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This small change allows for resolvers to return Promises and still get resolved properly using the `SyncExecutor`.
| @syrusakbary thank you for merging. Would it be possible to release this and https://github.com/syrusakbary/promise as a new version? We are currently depending on local patches. Would be nice to get rid of them :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This small change allows for resolvers to return Promises and still get resolved properly using the
SyncExecutor.This small change combined with syrusakbary/promise#1 increases the performance in our app quite a bit for 'free'.