Editing a node on both enter and leave #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits April 19, 2016 15:44
Related GraphQL-js commit: graphql/graphql-js@4256230
Related GraphQL-js commit: graphql/graphql-js@f79ba42
| @sdcooke I'm happy with this approach. Feel free to port the commits you want! |
| Just resolved the merge conflict and merged the changes 😉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Starting small - I've just grabbed the first commits from GraphQL-js that haven't been ported yet and ported them:
graphql/graphql-js@4256230
graphql/graphql-js@f79ba42
I've just dived in without a particularly deep knowledge of the codebase so I hope I haven't screwed it up. If I'm wasting your time I'll stop! If you're happy with this approach I can comment on graphql-python/graphql-core#53 to let you know which commits I'm working on and keep going through them.