Only override non declared filters #1108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Feb 13, 2021
…or not) - Fix type of various filters (used to default to String) - Fix bug with contains introduced in previous PR - Fix bug with declared filters being overridden (see PR graphql-python#1108) - Fix support for ArrayField and add documentation
This was referenced Feb 13, 2021
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Feb 16, 2021
…or not) - Fix type of various filters (used to default to String) - Fix bug with contains introduced in previous PR - Fix bug with declared filters being overridden (see PR graphql-python#1108) - Fix support for ArrayField and add documentation
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Feb 16, 2021
…or not) - Fix type of various filters (used to default to String) - Fix bug with contains introduced in previous PR - Fix bug with declared filters being overridden (see PR graphql-python#1108) - Fix support for ArrayField and add documentation
zbyte64 pushed a commit that referenced this pull request Feb 23, 2021
* - Add filtering support for choice fields converted to graphql Enum (or not) - Fix type of various filters (used to default to String) - Fix bug with contains introduced in previous PR - Fix bug with declared filters being overridden (see PR #1108) - Fix support for ArrayField and add documentation * Fix for v3 Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
zbyte64 pushed a commit that referenced this pull request Feb 23, 2021
* - Add filtering support for choice fields converted to graphql Enum (or not) - Fix type of various filters (used to default to String) - Fix bug with contains introduced in previous PR - Fix bug with declared filters being overridden (see PR #1108) - Fix support for ArrayField and add documentation * Fix tests Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
Collaborator
| I believe this got fixed up with the recent merge of #1119 which restored the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As the docstring of
replace_csv_filtersalready states, declared filters should not be converted to InFilter/RangeFilter since it is possible that these are intentionally customised. This function is now actually also converting declared filters