minor code cleanups #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dfa1 commented Aug 31, 2020
| } | ||
| | ||
| public <K> Builder keyContexts(List<K> keys, List<Object> keyContexts) { | ||
| nonNull(keys); |
There was a problem hiding this comment.
here I believe the intent was to throw NPE, correct?
- missing Thread.currentThread().interrupt(); after catching InterruptedException - converting Object.nonNull to Assertions.nonNull - removing some vestigial @SuppressWarnings("unchecked")
dfa1 commented Aug 31, 2020
| } | ||
| | ||
| public static Throwable cause(CompletableFuture completableFuture) { | ||
| public static Throwable cause(CompletableFuture<?> completableFuture) { |
There was a problem hiding this comment.
not sure about this raw type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
thank you for this nice library. I would like to propose few minor fixes: