Reactive streams branch move reactive classes out of dataloader helper #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…aderHelper is way too big
bbakerman commented May 24, 2024
| return new ReactiveSupport.HelperIntegration<>() { | ||
| @Override | ||
| public StatisticsCollector getStats() { | ||
| return stats; |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
DataLoader helper was way to big. I move the reactive code into their own package with some helper call back integration for the code that came from DataLoaderHelper
I also renamed the class in line with their counter parts
BatchPublisher is the interface that users need to implemnt - BatchSubscriber is our implementation to read from it