This repository was archived by the owner on Dec 19, 2023. It is now read-only.
fix: test subscription not waiting the specified amount of time #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If numExpectedResponses was 0 or negative, the method did not work according to documentation, it did not wait out the specified amount of time as the condition in await() was fulfilled immediately. This resulted in waitAndExpectNoResponse and awaitAndGetAllResponses not working as specified in the documentation. The test suite was also updated to catch this issue in the future.
BlasiusSecundus force-pushed the feature/fix-subscription-test-waiting branch from 556e866 to dfd735c Compare 
| Thanks @BlasiusSecundus |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If
numExpectedResponseswas 0 or negative, the method did not work according to documentation, it did not wait out the specified amount of time as the condition in await() was fulfilled immediately.This resulted in
waitAndExpectNoResponseandawaitAndGetAllResponsesnot working as specified in the documentation.The test suite was also updated to catch this issue in the future.