Add Content-Length HTTP header for non-stream JSON responses. #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi, is there any comments on this? |
| @oliemansm maybe? |
| The problem is that this PR conflicts with #215 that results in a consideral performance improvement. Accepting this PR would undo those changes. I don't think this PR would lead to a better performance than the other PR, but you could do benchmarks and prove me wrong :) |
| @newkek That other PR actually ended up breaking things. so I've reverted it. Will manually merge your changes to the new refactoring I'm working on. |
| Wow I am coming back to this very late but thanks @oliemansm for taking care of this change. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This helps clients decode more efficiently HTTP responses.
I have left out the stream responses because I think the header doesn't apply there.
Also I have covered only the happy path (successful response), it seems errors are implicitly supposed to return a Content-Length of 0.