fix: make py4j pyspark api robust #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #743 +/- ## ======================================= Coverage 84.32% 84.32% ======================================= Files 63 63 Lines 3030 3030 Branches 350 350 ======================================= Hits 2555 2555 Misses 475 475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
james-willis approved these changes Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changes in how py4j pyspark API works. It looks like there is a problem with
mixins.scalawhen you are trying to work with them from Java (or py4j).This PR changes how it is called from py4j. Instead of chaining calls, it calls methods one by one because they have side-effects internally any way.
Why are the changes needed?
Fix #741