This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Fix Peak RPS calculation, shared tooltip and fix VU display in the Performance Overview #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Sea-you commented Apr 29, 2024
Sea-you commented - Add a fix to the Peak RPS calculation by adding the Reduce (to max) transformation.
- Set shared tooltip in the Performance Overview panel
- Calculate the number of VUs by summing instead of average as it might mislead if you're testing with multiple instances. In our case 4 nodes, each 250 VUs. Previously this would have been displayed as 250 instead of 1000.
Sea-you requested review from mstoykov and olegbespalov and removed request for a team 
|
|
ppcano reviewed Apr 29, 2024
ppcano approved these changes Apr 29, 2024
olegbespalov approved these changes Apr 29, 2024
| @Sea-you, thanks for fixing the issue, improving the dashboard, and sharing it with the community! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.