Fix arm build #132
Fix arm build #132
Conversation
When trying to build for ARM (linux/arm), you get: ``` pkg/remote/client.go:120:35: cannot use 0xffffffff (untyped int constant 4294967295) as int value in argument to fmt.Errorf (overflows) ``` Pass the constant as unsigned integer. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
| return nil, fmt.Errorf("the protobuf message is too large to be handled by Snappy encoder; "+ | ||
| "size: %d, limit: %d", len(b), 0xffffffff) | ||
| "size: %d, limit: %d", len(b), uint(0xffffffff)) |
There was a problem hiding this comment.
@mem thanks for your contribution 🎉 🙇
It sounds to me the issue is more running on a 32-bit platform than being ARM. Am I missing something?
If my assumption is correct than doing the cast would generate a bad error message because the value is different based on the bit size for the Snappy library.
Something like the following should be more accurate:
maxLen = math.MaxInt32 if bits.UintSize == 64 { maxLen = 0xffffffff } There was a problem hiding this comment.
ah, you are right, nice catch
| Unfortunately k6 "dropped" 32 bit support a while back grafana/k6#1999 mostly due to lack of anyone using it and there being problems we will likely find only through a lot of usage. I feel like the problem here is that @mem you compiled for the "wrong" arm variant? Also the main k6 repo currently outputs: |
| I will close this now. Please open an issue if this is still needed so we can dicuss it |
When trying to build for ARM (linux/arm), you get:
Pass the constant as unsigned integer.
Fixes: #131