Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Add prometheus variable for datasource #114

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Add prometheus variable for datasource #114

merged 2 commits into from
Apr 3, 2023

Conversation

7olstoy
Copy link
Contributor

@7olstoy 7olstoy commented Mar 27, 2023

These values of datasource were hardcoded and does not use the variable.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@javaducky javaducky self-requested a review March 28, 2023 12:22
javaducky
javaducky suggested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @7olstoy! Thank you for your update. Looks like you're missing the definition for the DS_PROMETHEUS variable.

image
@7olstoy
Copy link
Contributor Author

7olstoy commented Apr 1, 2023

Hey @javaducky, thank you for your catch!
Added the variable and the same requires as already exist in another files.
javaducky
javaducky approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fix.
@javaducky javaducky merged commit bc5f307 into grafana:main Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants
@7olstoy @CLAassistant @javaducky