Skip to content

Conversation

@kevinwcyu
Copy link
Contributor

What this PR does / why we need it:

  • Fixes an issue where percentile metric query types were not being processed. processAggregationDocs did not have a case for the percentilesType type so it was not processing it correctly.
  • Fixes an issue where extended stats metric query types only returned 1 value, if multiple were specified in the query (e.g. if you selected min and max, it would only return max. The break statement caused the processing to only process the first extended stat metric.
  • Fixes an issue where the extended stats label only returned Extended Stats instead of Extended Stats {stat name} e.g. if min was one of the selected stats it should say Extended Stats Min in the label.

Which issue(s) this PR fixes:

Fixes #587

Special notes for your reviewer:

You can test this by:

  1. Build the data source
  2. yarn server
  3. Add sample data
  4. Run the queries below using the default provisioned data source

Query

query

Result

table

Explore

explore
@kevinwcyu kevinwcyu requested a review from a team as a code owner July 15, 2025 18:18
@kevinwcyu kevinwcyu requested review from idastambuk and iwysiu and removed request for a team July 15, 2025 18:18
Copy link
Contributor

@idastambuk idastambuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@kevinwcyu kevinwcyu force-pushed the kevinwcyu/587-fix-percentile-extended-stats branch from 1b562c4 to c6421d9 Compare July 16, 2025 15:33
@kevinwcyu kevinwcyu enabled auto-merge (squash) July 16, 2025 15:33
@kevinwcyu kevinwcyu force-pushed the kevinwcyu/587-fix-percentile-extended-stats branch from c6421d9 to f5ef01b Compare July 16, 2025 16:10
@kevinwcyu kevinwcyu merged commit 44d8504 into main Jul 16, 2025
21 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/587-fix-percentile-extended-stats branch July 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants