Fix adhoc filters with number fields #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iwysiu commented Jan 24, 2025
| text: bucket.key_as_string || bucket.key, | ||
| value: bucket.key, | ||
| text: bucket.key_as_string || keyString, | ||
| value: isTagValueQuery ? keyString : bucket.key, |
Contributor Author
There was a problem hiding this comment.
Technically MetricFindValue is supposed to accept numbers as values, but it was logging a console error instead of adding the filter when I tried it, it worked properly when it was a string.
iwysiu requested review from kevinwcyu and njvrzm and removed request for a team 
kevinwcyu approved these changes Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes adhoc filters with number fields
Which issue(s) this PR fixes:
Fixes grafana/grafana#99021
Special notes for your reviewer: