Bugfix: Update aws/aws-sdk-go to support Pod Identity credentials #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
idastambuk requested review from njvrzm and nmarrs and removed request for a team 
idastambuk changed the title 
idastambuk force-pushed the update-sdk branch from f9e5266 to dd361b2 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We had a bug reported with problems around using Pod Identity for AWS EKS. Looking through the docs it seems like our version of sdk should be updated to support it: https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html
Not sure if this is what caused it, but can't hurt to try it
Special notes for your reviewer:
Did a quick sanity check with local open search as well as sigv4 serverless from provisioning and the queries return 200.