Traces: Direct all trace queries to the BE and rename Node graph to Service map #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
idastambuk requested review from iwysiu and njvrzm and removed request for a team 
iwysiu approved these changes Apr 9, 2024
Contributor
iwysiu left a comment
iwysiu left a comment There was a problem hiding this comment.
Looks good, a couple questions though
| ], | ||
| }); | ||
| | ||
| it('can handle multiple trace list queries', async () => { |
Contributor
There was a problem hiding this comment.
Do these tests have backend equivalents/are they just unnecessary now?
Contributor Author
There was a problem hiding this comment.
It looks like there are some missing in the backend, added them!
iwysiu approved these changes Apr 11, 2024
Contributor
iwysiu left a comment
iwysiu left a comment There was a problem hiding this comment.
One comment, but tests look good!
| require.Len(t, result.Responses, 2) | ||
| | ||
| // 1st query | ||
| queryResTraceSpans1 := result.Responses["B"] |
Contributor
There was a problem hiding this comment.
Should one of these be A? Also totally optional, I know the original was very bare bones, but is there anything else we want to check in these to confirm parsing?
Contributor Author
There was a problem hiding this comment.
Done, added a check for operationName :)
njvrzm approved these changes Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I think it makes sense for us to redirect all trace queries to the backend before we release the Service Map feature. It's a BE feature and if we don't redirect all trace queries to the BE, we won't have feature parity in Dashboards vs. Explore
I also renamed node graph to Service Map, since it looks like 'service map' is used elswhere (X-ray, Elastic, Tempo) for the feature, and Node Graph is used for the Grafana visualization.
Special notes for your reviewer: