Fix: data links not working in explore for Trace List queries #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kevinwcyu requested review from njvrzm and sarahzinger and removed request for a team 
sarahzinger approved these changes Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Internal data link configs (data links that link to another data source) were added to the backend in 9.5.0. When Trace queries were added to OpenSearch, it added internal data links in the frontend. When we moved the Trace queries to run on the backend, the data links stopped working in pre 9.5.0 versions of Grafana since the backend response didn't have the internal data link config anymore. This PR adds the logic to populate the internal link config only for Trace List queries and only for the Trace Id field, it should leave all other data link configs untouched.
Which issue(s) this PR fixes:
Fixes #348
Special notes for your reviewer:
For testing, see the contributing doc for instructions on how to set up traces for OpenSearch.