Skip to content

Conversation

inancgumus
Copy link
Contributor

@inancgumus inancgumus commented Oct 6, 2025

What?

Fix linter errors (example) and warnings.

internal/js/modules/k6/browser/tests/frame_test.go:341:34: non-constant format string in call to (*go.k6.io/k6/internal/js/modules/k6/browser/k6ext/k6test.VU).RunPromise internal/js/modules/k6/browser/tests/frame_test.go:402:31: non-constant format string in call to (*go.k6.io/k6/internal/js/modules/k6/browser/k6ext/k6test.VU).RunAsync internal/js/modules/k6/browser/tests/page_test.go:2968:34: non-constant format string in call to (*go.k6.io/k6/internal/js/modules/k6/browser/k6ext/k6test.VU).RunPromise internal/js/modules/k6/browser/tests/page_test.go:3026:31: non-constant format string in call to (*go.k6.io/k6/internal/js/modules/k6/browser/k6ext/k6test.VU).RunAsync internal/js/modules/k6/browser/common/connection.go:661:1: File is not properly formatted (gofumpt) internal/js/modules/k6/browser/k6ext/panic.go:21:1: printf-like formatting function 'Abort' should be named 'Abortf' (goprintffuncname) internal/js/modules/k6/browser/k6ext/panic.go:33:1: printf-like formatting function 'Panic' should be named 'Panicf' (goprintffuncname) 

Why?

Maintenance and passing the CI linter errors, here.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
@inancgumus inancgumus added this to the v1.4.0 milestone Oct 6, 2025
@inancgumus inancgumus self-assigned this Oct 6, 2025
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 6, 2025 18:49 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 6, 2025 18:51 — with GitHub Actions Inactive
@inancgumus inancgumus marked this pull request as ready for review October 6, 2025 19:12
@inancgumus inancgumus requested a review from a team as a code owner October 6, 2025 19:12
@inancgumus inancgumus requested review from mstoykov and AgnesToulet and removed request for a team October 6, 2025 19:12
@mstoykov
Copy link
Contributor

mstoykov commented Oct 7, 2025

AFAICS this is already part of #5209 + other stuff + updating to latest golangci-lint

@inancgumus
Copy link
Contributor Author

AFAICS this is already part of #5209 + other stuff + updating to latest golangci-lint

@mstoykov
I can send this commit to #5209's branch after removing Abortf and Panicf updates. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants