[GR-51916] Add missing JUnit 5 init policies. #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oracle-contributor-agreement bot added the OCA Verified 
fniephaus changed the title 
fniephaus force-pushed the fniephaus/GR-51916/junit-fix branch from 54f10b6 to 106a622 Compare 
dnestoro approved these changes Feb 8, 2024
melix approved these changes Feb 8, 2024
| Don't forget to add something to the release notes. |
[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR marks additional JUnit 5 types for build-time init, allowing them to become part of the image heap. This is required for
--strict-image-heap. These additional types, however, aren't allocated as part of the NBT test harness. I have found those running./gradlew :test-suite-http-server-tck-netty:nativeTestCompileon the4.2.xbranch in the micronaut-core repo. The corresponding CI builds are currently failing due to this.