Add support for ProxyConnectHeader in the dialer. #988
+58 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add the ability to pass ProxyConnectHeader to the dialer. This set of headers will be used when a CONNECT request is made to an http(s) proxy.
This was referenced Jun 3, 2025
| @AlexVulaj would you be able to take a look at this PR? And thank you for working on Gorilla WebSocket, really appreciate it. https://github.com/open-telemetry/opamp-go that @michel-laterman and I work on depends on it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add the ability to pass ProxyConnectHeader to the dialer. This set of headers will be used when a CONNECT request is made to an http(s) proxy.
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing