Skip to content

Add Client Credentials Grant flow #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add Client Credentials Grant flow #83

wants to merge 8 commits into from

Conversation

@oshliaer
Copy link
Contributor

@oshliaer oshliaer commented Oct 5, 2017

Issue: #82
@erickoledadevrel
Copy link
Contributor

FYI, I am looking at this PR, but I think it calls into question some fundamental design choices in the library, so I'm thinking things through.
@oshliaer
Copy link
Contributor Author

@erickoledadevrel , I think I chose a wrong way. I'd like to re-build it to another variant.

I think It needs to use new properties app_key and app_secret like exchangeJwt.

For an example

 OAuth2.createService('drive') .setAppId('...') .setAppSecret('...')
@oshliaer
Copy link
Contributor Author

I've changed the implementation, but left the idea.
There are new methods:

  • setConsumerKey
  • setConsumerSecret
  • setGrantType

setGrantType is necessary for extension grants.
@oshliaer oshliaer mentioned this pull request Jul 24, 2018
Closed
@erickoledadevrel erickoledadevrel mentioned this pull request Jul 25, 2018
Merged
@erickoledadevrel
Copy link
Contributor

My apologies for leaving this in limbo for so long. I've adapted your work in #133, where I worked to centralize some of the logic and keep the implementation a bit more generic. Please take a look and let me know what you think. I'll close this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@oshliaer @erickoledadevrel