Update out of date packages and remove the node-fiber dependency #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…t is be marked obsolete and crashes node 16+. Rewrites tests dependent on it
Add StackOverflow sample
Use the `setParam` method of the OAuth2 library to add parameters. Cleaner code!
…nction for readability
* fix refresh token expiry lost during refresh * add failing test * revert previous changes to go with a different approach * stab at expires at variables * fix test and typo * fix typo * clean up code for easier review, minimize changes, follow previus patterns * add missing var * fix canRefresh logic * add setExpiresAt tests * remove extra comment * add tests and fix typo in logic Co-authored-by: Steve Bazyl <sbazyl@google.com>
* chore: Created local '.github/workflows/lint.yml' from remote 'sync-files/defaults/.github/workflows/lint.yml' * chore: Created local '.github/workflows/test.yml' from remote 'sync-files/defaults/.github/workflows/test.yml' * chore: Created local '.github/CODEOWNERS' from remote 'sync-files/defaults/.github/CODEOWNERS' * chore: Created local '.github/sync-repo-settings.yaml' from remote 'sync-files/defaults/.github/sync-repo-settings.yaml' * chore: Created local '.github/workflows/automation.yml' from remote 'sync-files/defaults/.github/workflows/automation.yml' * chore: Created local 'SECURITY.md' from remote 'SECURITY.md'
…ync-files/defaults/.github/workflows/automation.yml' (#383)
…ync-files/defaults/.github/workflows/automation.yml' (#385)
* chore: Synced local '.github/sync-repo-settings.yaml' with remote 'sync-files/defaults/.github/sync-repo-settings.yaml' * chore: Synced local '.github/workflows/automation.yml' with remote 'sync-files/defaults/.github/workflows/automation.yml'
* fix refresh token expiry lost during refresh * add failing test * revert previous changes to go with a different approach * stab at expires at variables * fix test and typo * fix typo * clean up code for easier review, minimize changes, follow previus patterns * add missing var * fix canRefresh logic * add setExpiresAt tests * remove extra comment * add tests and fix typo in logic Co-authored-by: Steve Bazyl <sbazyl@google.com>
| Might need to rebase on main branch |
* fix refresh token expiry lost during refresh * add failing test * revert previous changes to go with a different approach * stab at expires at variables * fix test and typo * fix typo * clean up code for easier review, minimize changes, follow previus patterns * add missing var * fix canRefresh logic * add setExpiresAt tests * remove extra comment * add tests and fix typo in logic Co-authored-by: Steve Bazyl <sbazyl@google.com>
…379) Previously, the getService method was public in most of the samples, letting any user of any sample application execute the method using google.script.run to exfiltrate the OAuth Client ID and Secret from the server. Now, these methods are made private by appending an _ to their names, preventing this issue.
* Add sample for Onshape * Make getService private
* fix refresh token expiry lost during refresh * add failing test * revert previous changes to go with a different approach * stab at expires at variables * fix test and typo * fix typo * clean up code for easier review, minimize changes, follow previus patterns * add missing var * fix canRefresh logic * add setExpiresAt tests * remove extra comment * add tests and fix typo in logic Co-authored-by: Steve Bazyl <sbazyl@google.com>
* fix refresh token expiry lost during refresh * add failing test * revert previous changes to go with a different approach * stab at expires at variables * fix test and typo * fix typo * clean up code for easier review, minimize changes, follow previus patterns * add missing var * fix canRefresh logic * add setExpiresAt tests * remove extra comment * add tests and fix typo in logic Co-authored-by: Steve Bazyl <sbazyl@google.com>
| Yeah, was trying to rebase locally but just got into a weird state. Reapplied the original changes in a new branch in #390. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates 3P packages to current versions and removes node-fiber. Node-fiber is no longer supported and is considered obsolete, and also causes node 16+ to crash. Rewrites a few tests + mocks to no longer depend on it.
Unfortunate side effect is the tests for locking aren't testing thread safety any more. It might be possible in the future to recreate apps script semantics via worker threads. For now, this relaxes the tests so builds aren't locked in to old versions of node.