Skip to content

Conversation

@Richisfree
Copy link

Although this is very similar to the Xero API example. Have added some helper functions to deal with multiple tenants that I found tricky also (in my case connecting to 2 x Xero and 2 x WFM tenants).

Although this is very similar to the Xero API example. Have added some helper functions to deal with multiple tenants that I found tricky also (in my case connecting to 2 x Xero and 2 x WFM tenants).
@google-cla
Copy link

google-cla bot commented Nov 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Richisfree
Copy link
Author

Have signed the CLA too.

@erickoledadevrel
Copy link
Contributor

Thanks for the contribution, but this sample seems to add very little that isn't already covered in the existing Xero sample. Given that the scope of this library is OAuth2, and the OAuth flow is the same for both APIs, I don't think a separate sample is needed in this case. While juggling tenant IDs can probably get tricky, I think that problem is a bit outside the scope of what these samples are trying to show.

@Richisfree
Copy link
Author

Richisfree commented Nov 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants