- Notifications
You must be signed in to change notification settings - Fork 456
WorkFlowMax #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorkFlowMax #250
Conversation
Although this is very similar to the Xero API example. Have added some helper functions to deal with multiple tenants that I found tricky also (in my case connecting to 2 x Xero and 2 x WFM tenants).
| Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
| Have signed the CLA too. |
| Thanks for the contribution, but this sample seems to add very little that isn't already covered in the existing Xero sample. Given that the scope of this library is OAuth2, and the OAuth flow is the same for both APIs, I don't think a separate sample is needed in this case. While juggling tenant IDs can probably get tricky, I think that problem is a bit outside the scope of what these samples are trying to show. |
| @googlebot I signed it! …On Fri, Nov 20, 2020 at 11:21 AM google-cla[bot] ***@***.***> wrote: Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 *Please visit https://cla.developers.google.com/ <https://cla.developers.google.com/> to sign.* Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it. ------------------------------ What to do if you already signed the CLA Individual signers - It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers - Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version <https://opensource.google/docs/cla/#troubleshoot>). - The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. - The email used to register you as an authorized contributor must also be attached to your GitHub account <https://github.com/settings/emails>. ℹ️ *Googlers: Go here <https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogleworkspace%2Fapps-script-oauth2%2Fpull%2F250> for more info*. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG55ZNLBJ43M5BZVQHOZVFDSQXOEJANCNFSM4T4HLHAA> . -- *Richard Haynes* Co-CEO *eTool* t: +61 8 9467 1664 | m: +61 0411 141 246 | e: richard@etoolglobal.com a: Level 2 18 Howard St Perth | www.etoolglobal.com LinkedIn <https://www.linkedin.com/company/2530061> | Facebook <https://www.facebook.com/eTool.LCA> | Twitter <https://twitter.com/eTool_LCA> Did you know that approximately 20% of the world's deforestation is for the purposes of making paper? Please consider our environment before printing this email. This email and any file attachments are for the named person's use only. It may contain confidential or legally privileged information or both. No confidentiality or privilege is waived or lost by any mistransmission. If you have received this correspondence in error please immediately delete it from your system and notify the sender. Any views expressed in this message are those of the individual sender, except where the sender expressly, and with authority, states them to be the views of eTool. |
Although this is very similar to the Xero API example. Have added some helper functions to deal with multiple tenants that I found tricky also (in my case connecting to 2 x Xero and 2 x WFM tenants).