Skip to content

Conversation

@ad-walker
Copy link
Contributor

Update of Quickbooks OAuth1 example to support OAuth2.

Update of Quickbooks OAuth1 example to support OAuth2.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@ad-walker
Copy link
Contributor Author

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated style per linter.

Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes per style guide.

Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace removal.

Copy link
Contributor

@erickoledadevrel erickoledadevrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this sample! Just a few small comments / changes.

• Added top level comment in keeping with other examples. • Replaced calls to PropertiesService with service.getStorage(). • Inlined multiple URLs in getService(). • Removed extraneous logging.
Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates based on erickoledadevrel suggestions.

Corrected line length per code standard.
Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected line length and trailing spaces.

Line length of 80 will be the death of me...
Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length.

Remove trailing whitespace.
Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace.

Removed last call to PropertiesService.getUserProperties()
Copy link
Contributor Author

@ad-walker ad-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed last call to PropertiesService.getUserProperties().

Copy link
Contributor

@erickoledadevrel erickoledadevrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@erickoledadevrel erickoledadevrel merged commit 6802ca5 into googleworkspace:master Feb 7, 2019
@ad-walker ad-walker deleted the patch-1 branch April 23, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants