Add a sample web app #135
Add a sample web app #135
Conversation
samples/WebApp/Callback.html Outdated
| | ||
| <script> | ||
| var email = '<?= email ?>'; | ||
| var isSignedIn = '<?= isSignedIn ?>' == 'true'; |
There was a problem hiding this comment.
Always use ===.
sed -i -e 's/==/===/g' **/*.*
samples/WebApp/Callback.html Outdated
| @@ -0,0 +1,50 @@ | |||
| <!-- | |||
| * Copyright 2016 Google Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
This line has changed since 2016; Google is a LLC. See go/releasing or look here:
Copyright 2018 Google LLC | /** | ||
| * Gets the user's GitHub repos. | ||
| */ | ||
| function getGitHubRepos() { |
There was a problem hiding this comment.
Combine getGitHubRepos and getGitHubProfile.
These method are too similar. I only see 1 difference (url).
There was a problem hiding this comment.
Kept them as separate methods, but combined the common bits.
| * Create a wrapped version of google.script.run that | ||
| * is adapted for Angular promises. | ||
| */ | ||
| var ScriptService = function($q) { |
There was a problem hiding this comment.
What is $q? Please document.
There was a problem hiding this comment.
It's a standard Angular module. Added an @see annotation with a link.
| return $q(function(resolve, reject) { | ||
| google.script.run | ||
| .withSuccessHandler(resolve) | ||
| .withFailureHandler(reject) |
There was a problem hiding this comment.
No, the next line is part of the same statement.
| }; | ||
| | ||
| /** | ||
| * The controller for the sample. |
There was a problem hiding this comment.
They aren't really parameters, but Angular dependencies. $scope is always just one thing, as with $window. script and intercom are services defined below. There really isn't anything to say about them individually.
samples/WebApp/README.md Outdated
| 1. Run the following commands: | ||
| ```sh | ||
| clasp version "Initial version" | ||
| clasp deploy 1 "Web App" |
There was a problem hiding this comment.
You could just clasp deploy unless you really want the version description.
samples/WebApp/README.md Outdated
| | ||
| ## AngularJS | ||
| | ||
| This web app uses the [AngularJS 1 framework](https://angularjs.org/) to make it |
There was a problem hiding this comment.
- Why don't we upgrade to Angular 2?
- Can we say Angular instead of AngularJS?
There was a problem hiding this comment.
As mentioned in the PR description, I took the existing Add-on sample and converted it into a web app. I don't think it's worth the effort to upgrade to the latest Angular version, as I believe it's not a straightforward upgrade process.
.gitignore Outdated
| @@ -1,2 +1,4 @@ | |||
| node_modules/ | |||
| *.log | |||
| samples/**/Secrets.gs | |||
There was a problem hiding this comment.
Can you mention where we create this Secrets.gs file in the README or in a comment here?
| This sample web application connects to your GitHub account using the Apps | ||
| Script OAuth2 library and displays some information about the repositories you | ||
| own. It demonstrates some best practices for using this library in a web app. | ||
| |
There was a problem hiding this comment.
Please include a picture here.
Adapted the code in the sample add-on, but adjusted for a web app deployment. Moved the library's
.clasp.jsonfile to thesrc/directory so that clasp could be used to deploy the web app.