Add samples for UI Kit Details/Compact #422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
willum070 requested changes May 16, 2025
Collaborator
willum070 left a comment
willum070 left a comment There was a problem hiding this comment.
- Mismatched region tags
- Mismatched name in project.yaml (and one name that should use dash not underscore)
Collaborator
There was a problem hiding this comment.
Should be:
"name": "@js-api-samples/ui-kit-place-search-details",
Collaborator
There was a problem hiding this comment.
Please use only dashes in project names. Change to ui-kit-place-search-details-compact
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "name": "@js-api-samples/ui-kit-place-details-compact", | |||
Collaborator
There was a problem hiding this comment.
Should be:
"name": "@js-api-samples/ui-kit-place-search-details-compact",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added samples for Samples page: Nearby Search and Place Details; Nearby Search and Compact Place Details