Skip to content

fix: Only send mtlsEndpoint if it is non-null #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 5 commits into from
May 2, 2025
Merged

fix: Only send mtlsEndpoint if it is non-null #3767

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
feac5e5
fix: Only send mtlsEndpoint if it is non-null
lqiu96 Apr 28, 2025
a88b881
chore: Add tests for a the mtlsEndpoint check
lqiu96 May 2, 2025
d812dc8
chore: Add tests for a the mtlsEndpoint check
lqiu96 May 2, 2025
5e9533c
chore: Add tests for a the mtlsEndpoint check
lqiu96 May 2, 2025
4993145
chore: Manually throw exception for null mtlsEndpoint
lqiu96 May 2, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public static ClientContext create(StubSettings settings) throws IOException {
transportChannelProvider = transportChannelProvider.withEndpoint(endpoint);
}
transportChannelProvider = transportChannelProvider.withUseS2A(endpointContext.useS2A());
if (transportChannelProvider.needsMtlsEndpoint()) {
if (transportChannelProvider.needsMtlsEndpoint() && endpointContext.mtlsEndpoint() != null) {
transportChannelProvider =
transportChannelProvider.withMtlsEndpoint(endpointContext.mtlsEndpoint());
}
Expand Down
Loading